Fix Ubuntu build and runspace test by bergmeister · Pull Request #1340 · PowerShell/PSScriptAnalyzer

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bergmeister

Copy link

Collaborator

PR Summary

Bringing back my old code to bootstrap the .Net SDK in CI because it works. To me that -bootstrap is over-engineered and therefore hard to debug and does not even work well (it does not persist after closing the shell on Windows, therefore I do not use it for development anyway...)
As part of it it discovered a new test assertion failure (wrong expectation) that it fixes as well.

PR Checklist

@JamesWTruher JamesWTruher merged commit c393de4 into PowerShell:master

Sep 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmholt rjmholt Awaiting requested review from rjmholt

1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bergmeister @JamesWTruher