Fix Ubuntu build and runspace test by bergmeister · Pull Request #1340 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
JamesWTruher merged 4 commits intoPowerShell:masterfrom
Sep 13, 2019Merged
Fix Ubuntu build and runspace test#1340
JamesWTruher merged 4 commits intoPowerShell:masterfrom
Fix Ubuntu build and runspace test#1340
JamesWTruher merged 4 commits intoPowerShell:masterfrom
Conversation
Copy link
Collaborator
bergmeister
commented
Sep 13, 2019
bergmeister
commented
PR Summary
Bringing back my old code to bootstrap the .Net SDK in CI because it works. To me that -bootstrap is over-engineered and therefore hard to debug and does not even work well (it does not persist after closing the shell on Windows, therefore I do not use it for development anyway...)
As part of it it discovered a new test assertion failure (wrong expectation) that it fixes as well.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister added 4 commits
September 13, 2019 08:15
bergmeister
added
the
Area - Build
label
bergmeister
requested review from
JamesWTruher and
rjmholt
JamesWTruher approved these changes Sep 13, 2019
JamesWTruher
merged commit
c393de4
into
PowerShell:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment