Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead by bergmeister · Pull Request #1387 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
bergmeister merged 1 commit intoPowerShell:masterfrom
Jan 3, 2020Merged
Conversation
Copy link
Collaborator
bergmeister
commented
Jan 2, 2020
bergmeister
commented
PR Summary
In the past we could not remove them because it broke tests but now it seems that tests are OK.
There is a risk for a regression that is not covered by tests but especially with the new way of PSSA being hosted, it feels more worth of a try now.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister
added
the
Area - Build
label
bergmeister
requested review from
JamesWTruher and
rjmholt
rjmholt approved these changes Jan 3, 2020
bergmeister
changed the title
Remove legacy methods
Remove obsolete GetCommandInfoLegacy method and use GetCommandInfo instead
bergmeister
merged commit
1c0cfef
into
PowerShell:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment