change term to satisfy policheck requirements by JamesWTruher · Pull Request #1445 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
JamesWTruher merged 1 commit intoPowerShell:masterfrom
Apr 17, 2020Merged
change term to satisfy policheck requirements#1445
JamesWTruher merged 1 commit intoPowerShell:masterfrom
change term to satisfy policheck requirements#1445
JamesWTruher merged 1 commit intoPowerShell:masterfrom
Conversation
Copy link
Contributor
JamesWTruher
commented
Apr 17, 2020
JamesWTruher
commented
PR Summary
change term 'hang' to approved verbiage
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
JamesWTruher
requested a review
from rjmholt
rjmholt approved these changes Apr 17, 2020
bergmeister approved these changes Apr 17, 2020
Copy link
Collaborator
bergmeister
left a comment
bergmeister
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, if that's what it takes to make the tool happy, then why not 😂
bergmeister
added
the
Area - Build
label
Copy link
Contributor Author
JamesWTruher
commented
Apr 17, 2020
JamesWTruher commented
Apr 17, 2020Lol, if that's what it takes to make the tool happy, then why not 😂
part of the MS policy checks we're required to do
JamesWTruher
merged commit
1971035
into
PowerShell:master
JamesWTruher
deleted the
policheckFixes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment