Make sure that tests results file gets uploaded in CI when there is a test failure by bergmeister · Pull Request #1455 · PowerShell/PSScriptAnalyzer
Conversation
PR Summary
Due to too much indentation condition was not applied, I did test in another branch that in case there is a test failure, it actually works.
And that my friends is why I (don't) love yaml....
https://noyaml.com/
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
…, condition was not applied
bergmeister
changed the title
Make sure that tests results file always get uploaded in CI (due to too much indentation condition was not applied)
Make sure that tests results file also gets uploaded in CI when there is a test failure
bergmeister
changed the title
Make sure that tests results file also gets uploaded in CI when there is a test failure
Make sure that tests results file gets uploaded in CI when there is a test failure
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters