Upgrade to use .NET 6 since PowerShell 7.0 is now out out of support by bergmeister · Pull Request #1873 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
Upgrade to use .NET 6 since PowerShell 7.0 is now out out of support#1873
bergmeister merged 1 commit intoPowerShell:masterfrom
Upgrade to use .NET 6 since PowerShell 7.0 is now out out of support#1873
bergmeister merged 1 commit intoPowerShell:masterfrom
Conversation
Copy link
Collaborator
PR Summary
Only PowerShell 7.2 and 7.3 are supported at the moment, which are using .NET 6 and 7, therefore we can bump our version of .NET as well.
fixes #1919
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister
added
the
Area - Build
label
Copy link
Contributor
fflaten
commented
Feb 27, 2023
fflaten commented
Feb 27, 2023Remember to bump devcontainer-image as well :)
bergmeister
mentioned this pull request
Copy link
peterhoeg
commented
May 26, 2023
peterhoeg commented
May 26, 2023Doesn't this need to change too:
Line 5 in 9f456d0
| <TargetFrameworks>netstandard2.0;net462</TargetFrameworks> |
?
JamesWTruher approved these changes Aug 21, 2023
Copy link
Contributor
JamesWTruher
left a comment
JamesWTruher
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Copy link
Collaborator Author
bergmeister
commented
Sep 17, 2023
bergmeister commented
Sep 17, 2023Doesn't this need to change too:
Line 5 in 9f456d0
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks> ?
No, net 462 is for windows powershell and .net 6 still implements .net standard 2
bergmeister
merged commit
772997f
into
PowerShell:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment