Do not hard code common parameters in module help test any more by bergmeister · Pull Request #1963 · PowerShell/PSScriptAnalyzer
Navigation Menu
{{ message }}
PowerShell / PSScriptAnalyzer Public
- Notifications You must be signed in to change notification settings
- Fork 406
Merged
bergmeister merged 1 commit intoPowerShell:masterfrom
Feb 13, 2024Merged
Do not hard code common parameters in module help test any more#1963
bergmeister merged 1 commit intoPowerShell:masterfrom
Do not hard code common parameters in module help test any more#1963
bergmeister merged 1 commit intoPowerShell:masterfrom
Conversation
Copy link
Collaborator
bergmeister
commented
Feb 2, 2024
bergmeister
commented
PR Summary
To prevent the test from failing again in future if PowerShell adds common parameters. Also checked that this works in WMF4 build that I still run in my fork.
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Change is not breaking
- Make sure all
.cs,.ps1and.psm1files have the correct copyright header - Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
- This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix
WIP:to the beginning of the title and remove the prefix when the PR is ready.
- If the PR is work in progress, please add the prefix
bergmeister
added
the
Area - Test
label
bergmeister
enabled auto-merge (squash)
bergmeister
requested a review
from JamesWTruher
JamesWTruher approved these changes Feb 13, 2024
Copy link
Contributor
JamesWTruher
left a comment
JamesWTruher
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bergmeister
merged commit
6cb66c1
into
PowerShell:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment