Add CodeQL suppressions for PowerShell intended behavior by anamnavi · Pull Request #25359 · PowerShell/PowerShell
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 8.2k
Conversation
PR Summary
This pull request includes several comments added to the code to address CodeQL warnings in the PowerShell codebase. The comments explain why the flagged issues are expected behavior and not security concerns.
Key changes include:
-
AddType.cs:- Added a comment to explain that allowing users to load any C# dependencies is integral to the purpose of the class and expected behavior.
-
WebRequestPSCmdlet.Common.cs:- Added a comment to clarify that PowerShell is an on-premise product, so information exposure through exceptions is not a security concern in the same way it would be for an ASP .NET service.
-
ExecutionContext.cs:- Added a comment to explain that loading DLLs during the initial state setup is expected behavior, allowing users to load additional C# types for specific scenarios.
PR Context
PR Checklist
- PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
- Summarized changes
- Make sure all
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header - This PR is ready to merge. If this PR is a work in progress, please open this as a Draft Pull Request and mark it as Ready to Review when it is ready to merge.
- Breaking changes
- None
- OR
- Experimental feature(s) needed
- Experimental feature name(s):
- User-facing changes
- Not Applicable
- OR
- Documentation needed
- Issue filed:
- Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
auto-merge was automatically disabled
April 14, 2025 22:51Head branch was pushed to by a user without write access
Sysoiev-Yurii pushed a commit to Sysoiev-Yurii/PowerShell that referenced this pull request
May 12, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters