Bump to Node 22.15.1 and remove `node-fetch` by JustinGrote · Pull Request #5214

Bump to Node 22.15.1 and remove `node-fetch` by JustinGrote · Pull Request #5214 · PowerShell/vscode-powershell

PR Summary

Bumps to Node 22.15.1 and removes node-fetch. Requires VSCode v1.101 or higher for future extension releases.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

PR has a meaningful title
Summarized changes
PR has tests
This PR is ready to merge and is not work in progress
- If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copilot AI review requested due to automatic review settings

June 12, 2025 21:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the extension’s supported VS Code version, bumps Node and TypeScript type dependencies, and removes the now-unnecessary node-fetch package.

Raise engines.vscode to ^1.101.0
Drop node-fetch and its type definitions in favor of Node’s built-in fetch
Bump @types/node to match Node v22.15.1 and update @types/vscode

Comments suppressed due to low confidence (2)

package.json:9

Consider adding an engines.node field (e.g., "node": ">=22.15.1") to package.json to enforce the minimum Node.js runtime version required by this extension.

package.json:63

Since node-fetch has been removed in favor of the native fetch API in Node.js, consider updating the README or CHANGELOG to document this change and any migration steps for consumers.

@andyleejordan eslint got real mad at me for unchanged stuff, do we want to fix these or add a rules exclusion?

@andyleejordan I rebased this commit and cleaned it up a bit, unless I was missing something in your comments it should be OK now and match your notes.

There is no TSConfig update needed, and now it mostly just needs the vscode and node packages bumped in the private packages and should be good.

Ran update again and updated the package feed. I now have to use artifacts-npm-credprovider to auth against, and that tool is so broken seriously it only worked once I deleted every line but registry=... from .npmrc. Even comments broke it

andyleejordan changed the title ~~Bump to Node 22.15.1 and removes node-fetch~~ Bump to Node 22.15.1 and remove node-fetch

Jul 23, 2025