Add custom package-zj-adps by caleeli · Pull Request #5852 · ProcessMaker/processmaker

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@caleeli

Copy link

Contributor

@caleeli caleeli commented

Dec 20, 2023

Add custom package-zj-adps

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ryancooley ryancooley merged commit 4b00c9f into develop

Dec 21, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julceslauhub julceslauhub julceslauhub approved these changes

+2 more reviewers

@boliviacoca boliviacoca boliviacoca approved these changes

@ronaldrodriguezbandeira ronaldrodriguezbandeira ronaldrodriguezbandeira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@caleeli @julceslauhub @boliviacoca @ronaldrodriguezbandeira @ryancooley