Use advanced filter for defaults and fix translations by nolanpro · Pull Request #6244 · ProcessMaker/processmaker

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@nolanpro

Copy link

Contributor

This PR fixes several issues

  • It uses advanced filters instead of PMQL for the default status for requests and tasks pages. Fixes 13931

These other issues were found and fixed:

  • Fixes an problem where column sorting broke when a default task and request pages are converted to system saved searches
  • Fixes translations by only translating when the string is displayed

Requires: https://github.com/ProcessMaker/package-savedsearch/pull/415

ci:next

@nolanpro nolanpro requested a review from caleeli

February 16, 2024 23:40
Copy link

Contributor

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@ryancooley ryancooley merged commit 446aa67 into next

Feb 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caleeli caleeli caleeli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nolanpro @caleeli @ryancooley