Use advanced filter for defaults and fix translations by nolanpro · Pull Request #6244 · ProcessMaker/processmaker
Navigation Menu
{{ message }}
ProcessMaker / processmaker Public
- Notifications You must be signed in to change notification settings
- Fork 246
Merged
Use advanced filter for defaults and fix translations#6244
ryancooley merged 2 commits intonextfrom
Use advanced filter for defaults and fix translations#6244
ryancooley merged 2 commits intonextfrom
Conversation
Copy link
Contributor
nolanpro
commented
Feb 16, 2024
nolanpro
commented
This PR fixes several issues
- It uses advanced filters instead of PMQL for the default status for requests and tasks pages. Fixes 13931
These other issues were found and fixed:
- Fixes an problem where column sorting broke when a default task and request pages are converted to system saved searches
- Fixes translations by only translating when the string is displayed
Requires: https://github.com/ProcessMaker/package-savedsearch/pull/415
ci:next
nolanpro added 2 commits
February 16, 2024 15:16Copy link
processmaker-sonarqube
bot
commented
Feb 16, 2024
processmaker-sonarqube bot commented
Feb 16, 2024
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
nolanpro
requested a review
from caleeli
caleeli approved these changes Feb 20, 2024
Copy link
Contributor
caleeli
left a comment
caleeli
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED
ryancooley
merged commit
446aa67
into
next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment