Launchpad mobile bookmarks by nolanpro · Pull Request #6956 · ProcessMaker/processmaker
Navigation Menu
{{ message }}
ProcessMaker / processmaker Public
- Notifications You must be signed in to change notification settings
- Fork 246
Merged
Launchpad mobile bookmarks#6956
nolanpro merged 4 commits intonext2-improvementsfrom
Launchpad mobile bookmarks#6956
nolanpro merged 4 commits intonext2-improvementsfrom
Conversation
Copy link
Contributor
nolanpro
commented
Jun 14, 2024
nolanpro
commented
Issue & Reproduction Steps
Bookmarks not working on launchpad mobile.
Solution
- Refactor launchpad bookmarks to work on mobile.
How to Test
See PRD and Figmas
Related Tickets & Packages
- https://processmaker.atlassian.net/browse/FOUR-16326
- https://processmaker.atlassian.net/browse/FOUR-16616
Code Review Checklist
- I have pulled this code locally and tested it on my instance, along with any associated packages.
- This code adheres to ProcessMaker Coding Guidelines.
- This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
- This solution fixes the bug reported in the original ticket.
- This solution does not alter the expected output of a component in a way that would break existing Processes.
- This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
- This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
- This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
- This ticket conforms to the PRD associated with this part of ProcessMaker.
nolanpro added 3 commits
June 12, 2024 13:46
nolanpro
requested a review
from gustavobascope
gustavobascope approved these changes Jun 14, 2024
Copy link
Contributor
gustavobascope
left a comment
gustavobascope
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Copy link
processmaker-sonarqube
bot
commented
Jun 14, 2024
processmaker-sonarqube bot commented
Jun 14, 2024
Quality Gate passed
Kudos, no new issues were introduced!
0 New issues
0 Security Hotspots
3.8% Coverage on New Code
0.0% Duplication on New Code
nolanpro
merged commit
7ba7282
into
next2-improvements
nolanpro
deleted the
feature/FOUR-16326
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment