Feature/pmio 432 by velkymx · Pull Request #2 · ProcessMaker/sketch

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Open

Feature/pmio 432#2

velkymx wants to merge 28 commits intomasterfrom

feature/PMIO-432

Conversation

@velkymx

Copy link

@velkymx velkymx commented

Jan 19, 2018

PR for adding exclusive gateways. Try two: Added missing resource files.

@velkymx velkymx requested a review from tdondich

January 19, 2018 18:49

@velkymx velkymx self-assigned this

Jan 19, 2018
Copy link

Contributor

@tdondich tdondich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Should include package-lock.json file.
  • Should rename inclusive gateway to something like merge existing exclusive.
  • Should gitignore public/js dir and the public/mix-manifest.js
  • Need the ability when selecting merge into existing exclusive, it creates an exclusive gateway merge point that can automatically merge the other path.
Sets on creation of gateway, updated when new elements are added.
It still seems unstable in use. The add element keys do not always line up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tdondich tdondich tdondich requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@velkymx velkymx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@velkymx @tdondich