MRG: Forgotten weights arg in barycenter funcs by hichamjanati · Pull Request #106 · PythonOT/POT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@hichamjanati

Copy link Copy Markdown

Contributor

@hichamjanati hichamjanati commented

Oct 19, 2019

edited

Loading

  • Tiny fix: the weights arg was not passed in the general barycenter funcs.
  • Loop counter in barycenter_unbalanced was outside the loop -> change while loops to for loops
  • Adding 1e-16 to avoid 0 when dual variables are returned was too conservative and causes large differences in the exponentials. changed to 1e-300

@hichamjanati hichamjanati changed the title FIX: Forgotten weights arg in barycenter funcs MRG: Forgotten weights arg in barycenter funcs

Oct 21, 2019

@rflamary rflamary merged commit 65ca6bf into PythonOT:master

Oct 24, 2019

@rflamary

Copy link Copy Markdown

Collaborator

Thank you Hicham !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hichamjanati @rflamary