MRG: Forgotten weights arg in barycenter funcs by hichamjanati · Pull Request #106 · PythonOT/POT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 544
Merged
rflamary merged 3 commits intoPythonOT:masterfrom
Oct 24, 2019Merged
MRG: Forgotten weights arg in barycenter funcs#106
rflamary merged 3 commits intoPythonOT:masterfrom
MRG: Forgotten weights arg in barycenter funcs#106
rflamary merged 3 commits intoPythonOT:masterfrom
Conversation
Copy link Copy Markdown
Contributor
- Tiny fix: the
weightsarg was not passed in the general barycenter funcs. - Loop counter in
barycenter_unbalancedwas outside the loop -> changewhileloops toforloops - Adding 1e-16 to avoid 0 when dual variables are returned was too conservative and causes large differences in the exponentials. changed to 1e-300
Hicham Janati added 3 commits
October 19, 2019 12:05
hichamjanati
changed the title
FIX: Forgotten weights arg in barycenter funcs
MRG: Forgotten weights arg in barycenter funcs
rflamary
merged commit
65ca6bf
into
PythonOT:master
Copy link Copy Markdown
Collaborator
rflamary
commented
Oct 24, 2019
rflamary commented
Oct 24, 2019Thank you Hicham !
rflamary
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment