[MRG] Actually run sphinx-gallery by rflamary · Pull Request #146 · PythonOT/POT

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@rflamary

Copy link Copy Markdown

Collaborator

up to new sphinx-gallery is executed offline and the resulting files are added to the git.

This PR aim at making it run on circle-ci in order to alwyas have current examples in the documentation.

@agramfort

Copy link Copy Markdown

Collaborator

need help @rflamary ?

@codecov-io

Copy link Copy Markdown

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   90.96%   90.96%           
=======================================
  Files          15       15           
  Lines        3023     3023           
=======================================
  Hits         2750     2750           
  Misses        273      273           
Copy link Copy Markdown

Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hichamjanati

Copy link Copy Markdown

Contributor

Woah 🎉 👍

@rflamary rflamary changed the title [WIP] Actually run sphinx-gallery [MRG] Actually run sphinx-gallery

Apr 21, 2020

@rflamary

Copy link Copy Markdown

Collaborator Author

Yes it is awesome.

I Updated the readme. Will merge as soon as i see no problems

@agramfort agramfort merged commit a303cc6 into master

Apr 21, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rflamary @agramfort @codecov-io @hichamjanati