[MRG] add normalization of distances for WDA by HexuanLiu · Pull Request #172

[MRG] add normalization of distances for WDA by HexuanLiu · Pull Request #172 · PythonOT/POT

Thank you for the pr.

Note that the tests failed because of pep8 violation that can be easily solved with autopep8. I will do a proper code review in the following days but note that the normalization should be an option in the function and be False by default to ensure that it will not break existing code.

ot/dr.py Outdated Show resolved Hide resolved

rflamary changed the title ~~add normalization of distances~~ [WIP] add normalization of distances for WDA

May 11, 2020

Codecov Report

Merging #172 (8e1a785) into master (79a7a29) will decrease coverage by 0.15%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   93.09%   92.94%   -0.16%     
==========================================
  Files          20       20              
  Lines        4228     4237       +9     
==========================================
+ Hits         3936     3938       +2     
- Misses        292      299       +7

rflamary changed the title ~~[WIP] add normalization of distances for WDA~~ [MRG] add normalization of distances for WDA

Oct 29, 2021