[MRG] Check metric is a string by zdk123 · Pull Request #379 · PythonOT/POT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 544
Merged
rflamary merged 1 commit intoPythonOT:masterfrom
May 16, 2022Merged
[MRG] Check metric is a string#379
rflamary merged 1 commit intoPythonOT:masterfrom
[MRG] Check metric is a string#379
rflamary merged 1 commit intoPythonOT:masterfrom
Conversation
Copy link Copy Markdown
Contributor
zdk123
commented
May 13, 2022
zdk123
commented
Types of changes
Resolves #378. The dist function needs an extra check that it's actually a string before calling a string method - mainly just in case the metric is a callable.
rflamary
changed the title
Check metric is a string
[MRG] Check metric is a string
Copy link Copy Markdown
Codecov Report
Merging #379 (fba7776) into master (b001d7a) will not change coverage.
The diff coverage is100.00%.
@@ Coverage Diff @@ ## master #379 +/- ## ======================================= Coverage 93.76% 93.76% ======================================= Files 23 23 Lines 5934 5934 ======================================= Hits 5564 5564 Misses 370 370
rflamary
merged commit
951209a
into
PythonOT:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants