[MRG] Debug sinkhorn divergence bug and add proper test by rflamary · Pull Request #394 · PythonOT/POT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 543
Merged
[MRG] Debug sinkhorn divergence bug and add proper test#394
[MRG] Debug sinkhorn divergence bug and add proper test#394
Conversation
Copy link Copy Markdown
Collaborator
Types of changes
Fixes #393
Motivation and context / Related issue
How has this been tested (if it applies)
PR checklist
- I have read the CONTRIBUTING document.
- The documentation is up-to-date with the changes I made (check build artifacts).
- All tests passed, and additional code has been covered with new tests.
- I have added the PR and Issue fix to the RELEASES.md file.
rflamary added 2 commits
August 17, 2022 17:20
rflamary
merged commit
a24ec25
into
master
rflamary
deleted the
bug_divergence
branch
agramfort reviewed Aug 17, 2022
|
|
||
| #### Closed issues | ||
|
|
||
| - Fixed an issue where sinkhorn divergence did not have a gradients (Issue #393, PR #394) |
Copy link Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove a before gradients
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants