[MRG] Add exact line-search for (f)gw solvers with kl_loss by cedricvincentcuaz · Pull Request #556 · PythonOT/POT
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 544
Conversation
Types of changes
- Add exact line-search for
ot.gromov.gromov_wassersteinandot.gromov.fused_gromov_wassersteinwhenloss_fun = 'kl_loss'which can be called by settingarmijo=False(default for the method). Note that these solvers ignored the providedarmijoparameter with this loss enforcingarmijo=True. - Extend
ot.gromov.solve_gromov_linesearchto any loss with common decomposition. - Adapt the behavior of dependent solvers that also enforced
armijo=True:ot.gromov.gromov_barycentersandot.gromov.fgw_barycenters - Add gradients in this setting for
ot.gromov.gromov_wasserstein2andot.gromov.fused_gromov_wasserstein2
Motivation and context / Related issue
How has this been tested (if it applies)
- Extended existing test for
ot.gromov.gromov_wassersteinandot.gromov.fused_gromov_wassersteinwith kl loss, looping over armijo values.
PR checklist
- I have read the CONTRIBUTING document.
- The documentation is up-to-date with the changes I made (check build artifacts).
- All tests passed, and additional code has been covered with new tests.
- I have added the PR and Issue fix to the RELEASES.md file.
Codecov Report
Merging #556 (e3f35cd) into master (53dde7a) will not change coverage.
The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #556 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 67 67 Lines 14663 14663 ======================================= Hits 14149 14149 Misses 514 514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters