[MRG] add kl_loss to all semi-relaxed (f)gw solvers by cedricvincentcuaz · Pull Request #559 · PythonOT/POT
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 543
Merged
cedricvincentcuaz merged 2 commits intoPythonOT:masterfrom
Nov 4, 2023Merged
[MRG] add kl_loss to all semi-relaxed (f)gw solvers#559
cedricvincentcuaz merged 2 commits intoPythonOT:masterfrom
[MRG] add kl_loss to all semi-relaxed (f)gw solvers#559
cedricvincentcuaz merged 2 commits intoPythonOT:masterfrom
Conversation
Copy link Copy Markdown
Collaborator
cedricvincentcuaz
commented
Nov 3, 2023
cedricvincentcuaz
commented
Types of changes
- Add
loss_fun="kl_loss"to all semi-relaxed (f)gw solvers. - line-search for conditional gradient solvers
solve_semirelaxed_gromov_linesearchnow support any decomposable functions as for gromov-wasserstein : implied to add a parameterfC2t(which corresponds to $f_2(C_2)^\top$ in this note). Previously existing parameters $C_1$ and $C_2$ should be past $h_1(C_1)$ and $h_2(C_2)$ as values - this is explained in the function documentation.
Motivation and context / Related issue
How has this been tested (if it applies)
- Extended most existing tests for these functions by looping over admissible values of
loss_fun.
PR checklist
- I have read the CONTRIBUTING document.
- The documentation is up-to-date with the changes I made (check build artifacts).
- All tests passed, and additional code has been covered with new tests.
- I have added the PR and Issue fix to the RELEASES.md file.
Copy link Copy Markdown
Codecov Report
Merging #559 (c2e5d4d) into master (a73ad08) will increase coverage by
0.00%.
The diff coverage is100.00%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #559 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 67 67 Lines 14663 14669 +6 ======================================= + Hits 14149 14155 +6 Misses 514 514
cedricvincentcuaz
merged commit
1071759
into
PythonOT:master
cedricvincentcuaz
deleted the
srgw_kl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment