Home Original page

[MRG] Fix order problems in (F)GW barycenters and utils by cedricvincentcuaz · Pull Request #576 · PythonOT/POT

Conversation

@cedricvincentcuaz

Types of changes

  • detail and fix operations in gromov.update_square_loss and gromov.update_kl_loss.
  • fix order of operations in (f)gw solvers using CG and entropic solvers.

Motivation and context / Related issue

How has this been tested (if it applies)

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed, and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov

Codecov Report

Merging #576 (b7179ad) into master (ef6c3c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          74       74           
  Lines       15036    15037    +1     
=======================================
+ Hits        14527    14528    +1     
  Misses        509      509

@cedricvincentcuaz cedricvincentcuaz changed the title [WIP] Fix order problems in (F)GW barycenters and utils [MRG] Fix order problems in (F)GW barycenters and utils

Nov 15, 2023

rflamary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1454,7 +1463,7 @@ def test_fgw_barycenter(nx):

with pytest.raises(ot.utils.UndefinedParameter): # to raise warning when `fixed_structure=True`and `init_C=None`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a warning but and error please

2 participants

@cedricvincentcuaz @rflamary