fix: Prevent loss of focus when deleting a workspace comment. by gonfunko · Pull Request #9200 · RaspberryPiFoundation/blockly
Navigation Menu
{{ message }}
RaspberryPiFoundation / blockly Public
- Notifications You must be signed in to change notification settings
- Fork 3.8k
Merged
fix: Prevent loss of focus when deleting a workspace comment.#9200
fix: Prevent loss of focus when deleting a workspace comment.#9200
Conversation
Copy link Copy Markdown
Contributor
gonfunko
commented
Jul 2, 2025
gonfunko
commented
The basics
The details
Resolves
This PR fixes a bug that could cause focus to be lost in keyboard navigation mode when deleting a workspace comment via its comment bar button.
gonfunko
requested a review
from a team
as a code owner
gonfunko
requested a review
from BenHenning
github-actions
bot
assigned
BenHenning
BenHenning reviewed Jul 2, 2025
core/comments/delete_comment_bar_button.ts
Show resolved
Hide resolved
core/comments/delete_comment_bar_button.ts Show resolved Hide resolved
Copy link Copy Markdown
Collaborator
microbit-matt-hillsdon
commented
Jul 8, 2025
microbit-matt-hillsdon commented
Jul 8, 2025Just a quick comment to say that it would be great to get this one in.
BenHenning approved these changes Jul 8, 2025
gonfunko
deleted the
comment-delete-focus
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment