fix: Allow overriding `VariableModel` via `options.plugins`. by gonfunko · Pull Request #9257 · RaspberryPiFoundation/blockly

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gonfunko

Copy link Copy Markdown

Contributor

The basics

The details

Resolves

Fixes #9256

Proposed Changes

This PR updates VariableMap to retrieve the VariableModel class to be used based on the injection options.plugins. Previously, this could only be overridden by manually registering an alternative implementation with the registry as the default implementation.

@gonfunko gonfunko requested a review from a team as a code owner

July 28, 2025 19:42

@github-actions github-actions bot added the PR: fix

Fixes a bug

label

Jul 28, 2025

@gonfunko gonfunko force-pushed the inject-variable-model branch from 4486fb5 to 39dcb45 Compare

July 29, 2025 17:42

@gonfunko gonfunko merged commit 8a578f5 into develop

Jul 30, 2025

13 checks passed

@gonfunko gonfunko deleted the inject-variable-model branch

July 30, 2025 15:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Labels

PR: fix

Fixes a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Classes conforming to IVariableModel cannot be injected through plugins injection option

2 participants

@gonfunko @rachel-fenichel