fix: Fix displaying HTML elements in `FieldDropdown`. by gonfunko · Pull Request #9258 · RaspberryPiFoundation/blockly
Navigation Menu
{{ message }}
RaspberryPiFoundation / blockly Public
- Notifications You must be signed in to change notification settings
- Fork 3.8k
Merged
fix: Fix displaying HTML elements in FieldDropdown.#9258
fix: Fix displaying HTML elements in FieldDropdown.#9258
Conversation
Copy link Copy Markdown
Contributor
The basics
The details
Resolves
Fixes #9247
Proposed Changes
This PR fixes FieldDropdown to not attempt to spread HTMLElement menu options, which caused later checks for instanceof HTMLElement to fail. This allows HTML elements to be properly displayed in dropdown fields.
gonfunko
requested a review
from a team
as a code owner
gonfunko
requested a review
from maribethb
github-actions
bot
assigned
maribethb
maribethb reviewed Jul 28, 2025
core/field_dropdown.ts
Show resolved
Hide resolved
core/field_dropdown.ts Show resolved Hide resolved
maribethb approved these changes Jul 28, 2025
gonfunko
deleted the
html-dropdowns
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment