refactor(VariableMap): Stop using deprecated wrapper methods by tashee · Pull Request #9340 · RaspberryPiFoundation/blockly
Navigation Menu
{{ message }}
RaspberryPiFoundation / blockly Public
- Notifications You must be signed in to change notification settings
- Fork 3.8k
Merged
tashee merged 4 commits intoRaspberryPiFoundation:developfrom
Sep 24, 2025Merged
refactor(VariableMap): Stop using deprecated wrapper methods#9340
tashee merged 4 commits intoRaspberryPiFoundation:developfrom
refactor(VariableMap): Stop using deprecated wrapper methods#9340
tashee merged 4 commits intoRaspberryPiFoundation:developfrom
Conversation
Copy link Copy Markdown
Contributor
tashee
commented
Sep 3, 2025
tashee
commented
The basics
The details
Resolves
Fixes 8945 (#8945)
Proposed Changes
Replaced deprecated wrapper methods
tashee
requested a review
from a team
as a code owner
tashee
requested a review
from cpcallen
github-actions
bot
added
the
PR: refactor
label
cpcallen reviewed Sep 4, 2025
Copy link Copy Markdown
Collaborator
cpcallen
left a comment
cpcallen
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but a few small fixes.
tests/mocha/test_helpers/workspace.js
Outdated
Show resolved
Hide resolved
tests/mocha/test_helpers/workspace.js Outdated Show resolved Hide resolved
tests/mocha/field_variable_test.js
Outdated
Show resolved
Hide resolved
tests/mocha/field_variable_test.js Outdated Show resolved Hide resolved
tests/mocha/test_helpers/workspace.js
Outdated
Show resolved
Hide resolved
tests/mocha/test_helpers/workspace.js Outdated Show resolved Hide resolved
tests/mocha/variable_map_test.js
Show resolved
Hide resolved
tests/mocha/variable_map_test.js Show resolved Hide resolved
Copy link Copy Markdown
Collaborator
cpcallen
commented
Sep 4, 2025
cpcallen commented
Sep 4, 2025I see the Keyboard Navigation Automated Tests have failed. Unfortuantely one of those tests is really flaky. You should just re-run it until it passes.
I'll let you investigate the Node.js CI / build test failure.
Lint failure was due to one use of var instead of const.
tashee and others added 2 commits
September 24, 2025 11:13Co-authored-by: Christopher Allen <cpcallen+github@gmail.com>
cpcallen approved these changes Sep 24, 2025
tashee
enabled auto-merge (squash)
19 tasks
tashee
deleted the
tashee-core-8945
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment