fix: Make left and right arrow keys only navigate within the current block/comment by gonfunko · Pull Request #9531 · RaspberryPiFoundation/blockly
Navigation Menu
{{ message }}
RaspberryPiFoundation / blockly Public
- Notifications You must be signed in to change notification settings
- Fork 3.8k
Merged
gonfunko merged 5 commits intoadd-screen-reader-support-experimentalfrom
Jan 5, 2026Merged
Conversation
Copy link Copy Markdown
Contributor
gonfunko
commented
Dec 17, 2025
gonfunko
commented
The basics
The details
Proposed Changes
This PR updates the behavior of the left and right arrow keys to only navigate within the current block/workspace comment, rather than traversing through the entire workspace. This is in response to feedback from screen reader user testing. Up and down may still be used to navigate from block to block and across stacks.
gonfunko added 2 commits
December 17, 2025 13:52
gonfunko
requested a review
from a team
as a code owner
gonfunko
requested review from
BenHenning
and removed request for
a team
github-actions
bot
assigned
BenHenning
BenHenning reviewed Dec 18, 2025
Copy link Copy Markdown
Collaborator
BenHenning
left a comment
BenHenning
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gonfunko! Had a few comments, one of which is specifically looking for some clarity.
tests/mocha/cursor_test.js
Show resolved
Hide resolved
tests/mocha/cursor_test.js Show resolved Hide resolved
core/keyboard_nav/line_cursor.ts
Outdated
Show resolved
Hide resolved
core/keyboard_nav/line_cursor.ts Outdated Show resolved Hide resolved
core/keyboard_nav/line_cursor.ts
Show resolved
Hide resolved
core/keyboard_nav/line_cursor.ts Show resolved Hide resolved
Copy link Copy Markdown
Collaborator
BenHenning
commented
Dec 18, 2025
BenHenning commented
Dec 18, 2025Also, the keyboard nav tests look to be real failures but that's unsurprising since this is a bit change in left/right navigation.
gonfunko added 2 commits
December 19, 2025 09:33BenHenning approved these changes Dec 24, 2025
Copy link Copy Markdown
Collaborator
BenHenning
left a comment
BenHenning
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gonfunko. This LGTM!
core/keyboard_nav/line_cursor.ts
Show resolved
Hide resolved
core/keyboard_nav/line_cursor.ts Show resolved Hide resolved
gonfunko
merged commit
909c294
into
add-screen-reader-support-experimental
6 of 8 checks passed
gonfunko
deleted the
left-right
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment