upgrade serde and time by DvirDukhan · Pull Request #1210 · RedisJSON/RedisJSON

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@DvirDukhan

Copy link

This PR upgrades serde to 1.0.184 and time to 0.3.36.
This PR solves build issues on with rustc nightly.
This PR also solves some build issues on macos

serde = { version = "=1.0.184", features = ["derive"] }
serde_derive = "=1.0.184"

serde = { version = "=1.0.203", features = ["derive"] }
Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can unfreeze serde if we port the cargo-deny support from the other projects. See: https://github.com/RedisGears/RedisGears/blob/master/deny.toml

@DvirDukhan DvirDukhan force-pushed the dvirdu_upgrade_serde_and_time branch from e4d940a to f6aa801 Compare

July 2, 2024 14:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iddm iddm iddm left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DvirDukhan @iddm