BUG: Fixes StochasticNoseCone powerseries issue #838 by cazzopardi · Pull Request #839 · RocketPy-Team/RocketPy
Pull request type
- Code changes (bugfix, features)
Checklist
- All tests (
pytest tests -m slow --runslow) have passed locally -
CHANGELOG.mdhas been updated (if relevant)
Current behavior
The StochasticNoseCone class does not support "powerseries" nose cones (issue #838 )
New behavior
Closes issue #838 by adding the power parameter the constructor of StochasticNoseCone
Breaking change
- No
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 80.03%. Comparing base (
f17893b) to head (5de3ee7).
Report is 7 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@ ## develop #839 +/- ## =========================================== + Coverage 80.02% 80.03% +0.01% =========================================== Files 98 98 Lines 12004 12021 +17 =========================================== + Hits 9606 9621 +15 - Misses 2398 2400 +2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
cazzopardi
deleted the
bug/fix_stochastic_nose_cone_powerseries_issue_838
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters