Home Original page

ENH: Changing ellipses plot axis label by ArthurJWH · Pull Request #855 · RocketPy-Team/RocketPy

@ArthurJWH

@ArthurJWH ArthurJWH commented

Oct 3, 2025

•

edited by Gui-FernandesBR

Loading

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

The axis use North and East as labels
Screenshot 2025-10-05 170136

New behavior

Label the extremes of the axis as North-South and West-East
Screenshot 2025-10-05 165426

Breaking change

  • Yes
  • No

@ArthurJWH

Gui-FernandesBR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurJWH the PR is simple and straightforward, thx for that!

  1. Could you provide us a screenshot of your results please? This makes review easier since I won't have to run several simulations to obtain the new plots.
  2. Could you kindly update the CHANGELOG pls?

After these 2 points, I believe we will merge it directly.

@ArthurJWH

@codecov

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.28%. Comparing base (f17893b) to head (629316d).
⚠️ Report is 27 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #855      +/-   ##
===========================================
+ Coverage    80.02%   80.28%   +0.26%     
===========================================
  Files           98      104       +6     
  Lines        12004    12764     +760     
===========================================
+ Hits          9606    10248     +642     
- Misses        2398     2516     +118

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Gui-FernandesBR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurJWH friendly reminder to update the CHANGELOG pls

@ArthurJWH

@ArthurJWH

Gui-FernandesBR

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArthurJWH ArthurJWH deleted the enh/changing-ellipses-axis-label branch

October 15, 2025 00:30