Use the new way for AnimatedImageViewWrapper, fix the transition visual jump between placeholderImage and final image by dreampiggy · Pull Request #325 · SDWebImage/SDWebImageSwiftUI
Navigation Menu
{{ message }}
SDWebImage / SDWebImageSwiftUI Public
- Notifications You must be signed in to change notification settings
- Fork 258
Closed
dreampiggy wants to merge 3 commits intomasterfrom
dreampiggy wants to merge 3 commits intomasterfrom
Conversation
Copy link
Collaborator
dreampiggy
commented
Jul 1, 2024
dreampiggy
commented
This close the issue during the changes of #324
dreampiggy added 2 commits
July 1, 2024 16:21…al jump between placeholderImage and final image
Copy link
Collaborator Author
dreampiggy
commented
Jul 1, 2024
dreampiggy commented
Jul 1, 2024The private API wrapped is exposed by accident. So I'd decide to remove this. People who previouslly use onViewCreateBlock does not get effected
Copy link
Collaborator Author
Found serious regression on macOS. That _NSImageViewSimpleImageView no longer exists and cause SDAnimatedImageView animation buggy.
Close for now and use another workaround
dreampiggy
closed this
Copy link
Collaborator Author
compared to previous version:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment