Allows easy to use WebImage with `isAnimating` default to false and change to true later by dreampiggy · Pull Request #333 · SDWebImage/SDWebImageSwiftUI
Navigation Menu
{{ message }}
SDWebImage / SDWebImageSwiftUI Public
- Notifications You must be signed in to change notification settings
- Fork 257
Merged
Conversation
Copy link
Collaborator
dreampiggy
commented
Aug 28, 2024
dreampiggy
commented
Reason
Since SDAnimatedImage has fallback logic, we can apply this to WebImage by default without dynamic check
This close #332
…hange to true later Since SDAnimatedImage has fallback logic, we can apply this to WebImage by default without dynamic check
dreampiggy
force-pushed
the
bugfix/webimage_isAnimating_binding
branch
from
1b68c49 to
7efdf22
Compare
Copy link
joshuatbrown
commented
Aug 28, 2024
joshuatbrown commented
Aug 28, 2024I tested this branch in my app; it works perfectly for me and fixes #332. Thanks for the quick fix!
This was referenced
Aug 28, 2024
dreampiggy
merged commit
09dfa5a
into
master
dreampiggy
deleted the
bugfix/webimage_isAnimating_binding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants