Added emojies, lines diff checker, app name by marinakalyuzhnaya · Pull Request #19 · ScaCap/code-coverage-assistant

@marinakalyuzhnaya

Problem solved:

  1. added emojies to highlight comment with red/green colour for diff
  2. added possibility to show details only for changed lines , please note, that this will work only if you have base lcov file, if not previous code will work without changes
  3. added possibility to add app-name (needed mostly for singe repo with diff siblings)

@github-actions

Coverage after merging add-colors into master
100.00%
Coverage Report
FileBranchesFuncsLinesUncovered Lines
src
   html.js100%100%100%
   lcov.js100%100%100%
   tabulate.js100%100%100%

Weetbix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, saw it in action with your other PR

eeshdarthvader

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@marinakalyuzhnaya

@marinakalyuzhnaya marinakalyuzhnaya changed the title Added emojies to the comment diff part Added emojies, lines diff checker

Feb 5, 2021

@marinakalyuzhnaya

@marinakalyuzhnaya marinakalyuzhnaya changed the title Added emojies, lines diff checker Added emojies, lines diff checker, app name

Feb 5, 2021

janory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Weetbix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great again, I've seen it in action :)

eeshdarthvader

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few changes added.

@marinakalyuzhnaya

eeshdarthvader

@marinakalyuzhnaya

Looks great again, I've seen it in action :)

I already have some improvements ideas, how to show only changed lines without having a base file. :)

eeshdarthvader

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. ❤️

@marinakalyuzhnaya