Home Original page

Revert "[grid] Add config `blocked-routes` and specific `blocked-delete-session` in Router" by VietND96 · Pull Request #15921 · SeleniumHQ/selenium

@VietND96

User description

Reverts #15920. Since it was a complex solution and doesn't have a reality use case for that.

PR Type

Other

Description

• Reverts blocked routes feature from grid router
• Removes BlockedRoute and BlockedRoutesFilter classes
• Removes blocked-routes configuration options
• Removes related test files and build configuration

Changes walkthrough 📝

Relevant files
Bug fix
3 files
Hub.java
Remove blocked routes filter application                                 
+0/-10   
Standalone.java
Remove blocked routes filter application                                 
+0/-10   
RouterServer.java
Remove blocked routes filter application                                 
+0/-8     
Miscellaneous
2 files
BlockedRoute.java
Delete entire BlockedRoute class file                                       
+0/-221 
BlockedRoutesFilter.java
Delete entire BlockedRoutesFilter class file                         
+0/-86   
Configuration changes
2 files
RouterFlags.java
Remove blocked routes command line parameters                       
+0/-23   
RouterOptions.java
Remove blocked routes configuration methods                           
+0/-50   
Tests
3 files
BlockedRouteTest.java
Delete entire test class file                                                       
+0/-166 
BlockedRoutesFilterTest.java
Delete entire test class file                                                       
+0/-213 
RouterOptionsTest.java
Delete entire test class file                                                       
+0/-417 
Dependencies
1 files
BUILD.bazel
Delete test build configuration file                                         
+0/-18   
Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.

    • @VietND96 

    …te-sessi…"

This reverts commit 406427b.

    @qodo-code-review

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review
    Import Cleanup

    The removal of unused imports appears correct, but verify that no other parts of the codebase still reference the removed BlockedRoute or BlockedRoutesFilter classes to avoid compilation errors.

     
    import static java.net.HttpURLConnection.HTTP_OK;
import static java.net.HttpURLConnection.HTTP_UNAVAILABLE;
import static org.openqa.selenium.grid.config.StandardGridRoles.DISTRIBUTOR_ROLE;
import static org.openqa.selenium.grid.config.StandardGridRoles.EVENT_BUS_ROLE;
import static org.openqa.selenium.grid.config.StandardGridRoles.HTTPD_ROLE;
import static org.openqa.selenium.grid.config.StandardGridRoles.ROUTER_ROLE;
import static org.openqa.selenium.grid.config.StandardGridRoles.SESSION_QUEUE_ROLE;
import static org.openqa.selenium.remote.http.Route.combine;

import com.google.auto.service.AutoService;
import com.google.common.collect.ImmutableSet;
import java.net.MalformedURLException;
import java.net.URL;
import java.util.Collections;
import java.util.Set;
import java.util.logging.Level;
import java.util.logging.Logger;
import java.util.stream.Stream;
    Method Removal

    The getBlockedRoutes method has been completely removed. Ensure that no other components in the grid system are calling this method, as this could cause runtime failures if the revert is incomplete.

     
                  return prefix;
            })
        .orElse("");
  }

  public boolean disableUi() {
    return config.get(ROUTER_SECTION, "disable-ui").map(Boolean::parseBoolean).orElse(false);
  }
}

    @qodo-code-review

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @VietND96 VietND96 deleted the revert-15920-blocked-routes branch

    June 20, 2025 08:22