Home Original page

[rb] fix unit tests by aguspe · Pull Request #16357 · SeleniumHQ/selenium

and others added 15 commits

March 22, 2025 11:54

@aguspe aguspe changed the title Rb fix unit tests [rb] fix unit tests

Sep 29, 2025

cgoldberg referenced this pull request

Oct 7, 2025 
* update devtools versions

* update selenium manager versions

* update maven dependency versions

* update authors file

* bump versions in preparation for release

* WIP - rough auto-update of changelog, please edit

* Update sha256 for signed selenium-manager-windows.exe artifact

* Updating tests and linting readme.

* Updating Gemfile.lock

* Rolling back json upgrade

* Pinning rust lock

* Pinning rust lock

* Removing guards and switching to macOS

[skip ci]

* Removing guards

---------

Co-authored-by: Selenium CI Bot <selenium-ci@users.noreply.github.com>
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Co-authored-by: Boni Garcia <boni.garcia@uc3m.es>
Co-authored-by: Diego Molina <diemol@gmail.com>

Earlopain added a commit to Earlopain/selenium that referenced this pull request

Oct 15, 2025 
This project does not use prism at all. At most it is being used by rubocop during local development.

It was added in SeleniumHQ#16357 but it is unclear to me why.
I just bumped it for this repo, perhaps that JRuby issue has since been fixed.
Either way, it should not be part of the gemspec.

diemol added a commit that referenced this pull request

Oct 16, 2025 
* [rb] Remove `prism` dependency

This project does not use prism at all. At most it is being used by rubocop during local development.

It was added in #16357 but it is unclear to me why.
I just bumped it for this repo, perhaps that JRuby issue has since been fixed.
Either way, it should not be part of the gemspec.

* Pin prism to 1.4.0 for the project

It fails to build with the following error:
src/prism.c: In function ‘context_terminator’:
src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change
the sign of the result [-Werror=sign-conversion]
8651 |     return token->type < 32 && (context_terminators[context] & (1 <<
token->type));
      |                                                              ^
cc1: all warnings being treated as errors

---------

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>