Fix: Make BIC optional for Girocode Version 2 by Shane32 · Pull Request #622 · Shane32/QRCoder
- Modified IsValidBic to accept a 'required' parameter - BIC is now required for Version 1 (as per spec) - BIC is optional for Version 2 (as per spec) - Fixed NullReferenceException when BIC is null - Added comprehensive tests for all scenarios: - Version 2 with null BIC (passes) - Version 2 with empty BIC (passes) - Version 2 with valid BIC (passes) - Version 2 with invalid BIC (throws exception) - Version 1 with null BIC (throws exception) - Version 1 with empty BIC (throws exception) Fixes issue where Girocode constructor threw NullReferenceException when BIC was null with Version 2, which should be allowed per the Girocode specification.
added this to the
1.7.0 milestone
Shane32
deleted the
fix/girocode-version2-bic-optional
branch
This was referenced
Oct 9, 2025This was referenced
Nov 25, 2025This was referenced
Dec 5, 2025This was referenced
Oct 13, 2025This was referenced
Nov 25, 2025This was referenced
Dec 5, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters