Fix publish workflow by jeffcharles · Pull Request #510 · Shopify/function-runner

Fix publish workflow by jeffcharles · Pull Request #510 · Shopify/function-runner

Skip to content

Merged

jeffcharles merged 1 commit intomainfrom

jc.fix-publishing

Sep 19, 2025

Merged

Fix publish workflow#510
jeffcharles merged 1 commit intomainfrom
jc.fix-publishing

Conversation

Copy link Copy Markdown

Contributor

jeffcharles commented
Sep 19, 2025

merge-multiple defaults to false and will put each artifact inside its own directory whereas the existing code assumes all artifacts are in the artifacts directory
The gh release upload command either needs a Git checkout or needs the repository to specified

Fix publish workflow

adampetro approved these changes Sep 19, 2025

View reviewed changes

Copy link Copy Markdown

Contributor

adampetro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why this started breaking now?

Copy link Copy Markdown

Contributor Author

jeffcharles commented
Sep 19, 2025

#478 was merged after the last release. And I see some testing of it but I'm not sure that it was fully tested.

Copy link Copy Markdown

Contributor Author

jeffcharles commented
Sep 19, 2025

This fix I tested on releases on my fork of the repo

jeffcharles merged commit a02652e into main

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants