Fix mounting reset not working for feet by ButterscotchV · Pull Request #1508 · SlimeVR/SlimeVR-Server

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ButterscotchV

Copy link

Member

@ButterscotchV ButterscotchV commented

Jul 29, 2025

edited

Loading

Fixes after #1441
This fixes the headset reference not being used for resets that don't include the head. Also changes the tap reset default back to not including feet.
Since we don't have the foot reset toggle anymore, the GUI must be used to reset, we can maybe fix this in a better way after this PR?

Spazznyan reacted with heart emoji

@ButterscotchV ButterscotchV self-assigned this

Jul 29, 2025

@ButterscotchV ButterscotchV added Type: Bug

Something isn't working

Priority: High

Important feature or blocks something important

Area: Server

Related to the server

labels

Jul 29, 2025

@github-actions github-actions bot added the Area: Skeletal Model

Deals with the model of the skeleton and its pose

label

Jul 29, 2025

@Erimelowo Erimelowo merged commit a8116a7 into SlimeVR:main

Jul 29, 2025

9 checks passed

@Erimelowo

Copy link

Member

Since we don't have the foot reset toggle anymore, the GUI must be used to reset, we can maybe fix this in a better way after this PR?

Doing that

@ButterscotchV ButterscotchV deleted the mount-reset-fix branch

August 6, 2025 01:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loucass003 loucass003 loucass003 approved these changes

@Erimelowo Erimelowo Erimelowo approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

Labels

Area: Server

Related to the server

Area: Skeletal Model

Deals with the model of the skeleton and its pose

Priority: High

Important feature or blocks something important

Type: Bug

Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ButterscotchV @Erimelowo @loucass003