Home Original page

[Fix]: When destroying, failed to remove the dragover and dragenter events. by KonghaYao · Pull Request #2373 · SortableJS/Sortable

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@KonghaYao

Copy link Copy Markdown

When I repeated the destroy and mount events, I found that the dragover and dragenter events mounted by Sortablejs were not destroyed, which caused a bug. So I checked the source code and fixed the issue.

Haxxer and WankkoRee reacted with thumbs up emoji

@KonghaYao

Copy link Copy Markdown

Author

image
It looks like the tests on circleCI failed, but they were successful on my device. Windows 10.

@KonghaYao

Copy link Copy Markdown

Author

Because there was an error in the CircleCI pipeline, I upgraded testcafe and its related configurations directly so that it can run test scripts for everyone.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KonghaYao