Change pointers casting type by SpaiR · Pull Request #265 · SpaiR/imgui-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@SpaiR

Copy link

Owner

@SpaiR SpaiR commented

Aug 29, 2024

edited

Loading

  • uintptr_t is used instead of intptr_t to cast pointers.
  • Image methods now accept the long type instead of int, as they are expected to work with pointers as well.

resolves #185

Type of change

  • Minor changes or tweaks (quality of life stuff)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
Image methods now accept the `long` type instead of `int`,
as they are expected to work with pointers as well.

@SpaiR SpaiR added feat

New feature or request

api labels

Aug 29, 2024

@SpaiR SpaiR merged commit c4c03be into main

Aug 29, 2024

@SpaiR SpaiR deleted the feat/pointers-handling branch

August 29, 2024 13:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feat

New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ImGui.image() should expect long instead of int for textureId.

1 participant

@SpaiR