Make GeoRadiusResult constructor public to make it mockable by firenero · Pull Request #1175 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
NickCraver merged 1 commit intoStackExchange:masterfrom
Sep 27, 2019Merged
Make GeoRadiusResult constructor public to make it mockable#1175
NickCraver merged 1 commit intoStackExchange:masterfrom
Make GeoRadiusResult constructor public to make it mockable#1175
NickCraver merged 1 commit intoStackExchange:masterfrom
Conversation
Copy link Copy Markdown
Contributor
firenero
commented
Jul 6, 2019
firenero
commented
It's impossible to mock GeoRadius and GeoRadiusAsync methods now because GeoRadiusResult constructor is internal. Given that constructors for all other GEO calls are public I think it's possible to make GeoRadiusResult constructor public as well.
firenero
mentioned this pull request
NickCraver
added
⚙️ area:API
⚙️ area:geo
labels
Copy link Copy Markdown
Contributor Author
firenero
commented
Sep 18, 2019
firenero commented
Sep 18, 2019@NickCraver Can I help somehow to get it merged? Lack of public constructor here makes unit testing really hard for a while already.
NickCraver approved these changes Sep 27, 2019
Copy link Copy Markdown
Collaborator
NickCraver
left a comment
NickCraver
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 - we'll get this into the next build
Copy link Copy Markdown
Collaborator
NickCraver
commented
Sep 27, 2019
NickCraver commented
Sep 27, 2019I'm unsure on timeline for the next release, but it'll be on MyGet shortly.
NickCraver
merged commit
7f56a80
into
StackExchange:master
firenero
deleted the
public_geo_radius_ctor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment