Added "Return" parameter to Query. by oruchreis · Pull Request #1199 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
Added "Return" parameter to Query.#1199
mgravell merged 2 commits intoStackExchange:masterfrom
Added "Return" parameter to Query.#1199
mgravell merged 2 commits intoStackExchange:masterfrom
Conversation
mgravell reviewed Jul 29, 2019
| /// </summary> | ||
| /// <param name="fields">a list of TEXT fields in the schemas</param> | ||
| /// <returns>the query object itself</returns> | ||
| public Query LimitFields(params string[] fields) |
Copy link Copy Markdown
Collaborator
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a breaking change; any changes should preserve the existing API (it is OK to forward if needed)
Copy link Copy Markdown
Collaborator
mgravell
commented
Jul 29, 2019
mgravell commented
Jul 29, 2019most of the API here is a snapshot of what JRediSearch was at some point in time; do you know (I don't) what JRediSearch exposes here?
Copy link Copy Markdown
Contributor Author
Ok, I didn't know that this is a snapshot of JRediSearch API. It seems JRediSearch has the return parameter also inkeys parameter with different method name. https://github.com/RediSearch/JRediSearch/blob/5d8ea3c8d2f71eefde59d88c17bb92c65dfb95ed/src/main/java/io/redisearch/Query.java#L413
I'll update than.
Copy link Copy Markdown
Collaborator
mgravell
commented
Feb 3, 2020
mgravell commented
Feb 3, 2020Seems great; merging, thanks
mgravell
merged commit
37e257f
into
StackExchange:master
NickCraver
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants