Home Original page

Fix sentinel default port when connecting with configuration string by ejsmith · Pull Request #1525 · StackExchange/StackExchange.Redis

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ejsmith

Copy link Copy Markdown

Contributor

@ejsmith ejsmith commented

Jul 7, 2020

•

edited

Loading

This makes it so that when using a configuration string to connect that we only parse the configuration string and not set any defaults on it until it is forwarded on to the connect methods that take ConfigurationOptions

@niemyjski

Copy link Copy Markdown

@mgravell Any chance we can get this reviewed and merged?

@ejsmith

Copy link Copy Markdown

Contributor Author

ejsmith commented

Aug 25, 2020

@NickCraver @mgravell looks like you are getting ready to do another release. Think we can this small change merged? :-)

Copy link Copy Markdown

Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a few tweaks but looking good - thanks for this!

ejsmith reacted with thumbs up emoji

@NickCraver NickCraver merged commit ad94bd3 into StackExchange:main

Aug 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ejsmith @niemyjski @NickCraver