Improving ConfigCheckSeconds for a faster failover detection by deepakverma · Pull Request #1735 · StackExchange/StackExchange.Redis
Fixes info command storm on a disconnect
After a master node disconnect performs ConfigCheckSeconds on replica nodes with an exponential backoff
After a master node disconnect performs ConfigCheckSeconds on replica nodes with an exponential backoff
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one's good - would like a name tweak for clarity though please!
|
|
||
|
|
||
| // Forces frequent replication check starting from 1 second upto max ConfigCheckSeconds with an exponential increment | ||
| internal void ForceExponentiallyReplicationCheck() |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this for clarity please?
| internal void ForceExponentiallyReplicationCheck() | |
| internal void ForceExponentialBackoffReplicationCheck() |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looking good, thanks for the tweaks!
NickCraver
changed the title
improving configcheckseconds for a faster failover detection
Improving ConfigCheckSeconds for a faster failover detection
NickCraver pushed a commit that referenced this pull request
May 26, 2021
deepakverma
deleted the
MarkServerEndpointsForReplicationRoleRefresh
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters