Ensure valid timeout settings in ExponentialRetry by gliljas · Pull Request #1921 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
NickCraver merged 4 commits intoStackExchange:mainfrom
Feb 18, 2022Merged
Ensure valid timeout settings in ExponentialRetry#1921
NickCraver merged 4 commits intoStackExchange:mainfrom
Ensure valid timeout settings in ExponentialRetry#1921
NickCraver merged 4 commits intoStackExchange:mainfrom
Conversation
Copy link Copy Markdown
Contributor
Setting a timeout from the connectionstring can cause deltaBackOffMilliseconds to be higher than maxDeltaBackOffMilliseconds, which will cause an ArgumentOutOfRangeException ('minValue' cannot be greater than maxValue.) in ShouldRetry.
gliljas and others added 4 commits
December 1, 2021 11:25NickCraver approved these changes Feb 18, 2022
Copy link Copy Markdown
Collaborator
NickCraver
left a comment
NickCraver
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional checks here!
NickCraver
merged commit
a65b432
into
StackExchange:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants