Pub/Sub fixes for subscribe/re-subscribe by NickCraver · Pull Request #1947 · StackExchange/StackExchange.Redis
added 13 commits
January 10, 2022 08:59NickCraver added a commit that referenced this pull request
Jan 18, 2022This won't be fully accurate until #1947 fixed the PING routing, but getting a test fix into main ahead of time.
NickCraver added a commit that referenced this pull request
Jan 18, 2022This won't be fully accurate until #1947 fixed the PING routing, but getting a test fix into main ahead of time.
…nd cleanup In prep for changes to how we handle subscriptions internally, this does several things: - Upgrades default Redis server assumption to 3.x - Routes PING on Subscription keepalives over the subscription bridge appropriately - Fixes cluster sharding from default(RedisKey) to shared logic for RedisChannel as well (both in byte[] form) - General code cleanup in the area (getting a lot of DEBUG/VERBOSE noise into isolated files)
NickCraver
changed the base branch from
main
to
craver/pub-sub-prep
This is effectively the behavior we had before (but we are ensured connected now). We just want the count here and to start them, so let's do that also pipelining the `n` commands as we did before instead of awaiting each. We also don't need the `Task` overhead. This makes moving to a variadic command set for this less urgent.
This was referenced
Feb 4, 2022This was linked to issues
Feb 6, 2022This was referenced
Feb 6, 2022This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters