Pub/Sub fixes for subscribe/re-subscribe by NickCraver · Pull Request #1947 · StackExchange/StackExchange.Redis

added 13 commits

January 10, 2022 08:59
We're working on pub/sub - breaking it out explicitly.
*Now* this should be stable killing and restoring both connections with proper PING routing in place.
This awaits the condition, rather than a magical delay previously.

NickCraver added a commit that referenced this pull request

Jan 18, 2022
This won't be fully accurate until #1947 fixed the PING routing, but getting a test fix into main ahead of time.

NickCraver added a commit that referenced this pull request

Jan 18, 2022
This won't be fully accurate until #1947 fixed the PING routing, but getting a test fix into main ahead of time.

@NickCraver

@NickCraver

@NickCraver

@NickCraver

@NickCraver

Want to yank some of this into another PR ahead of time, getting files in.
…nd cleanup

In prep for changes to how we handle subscriptions internally, this does several things:
- Upgrades default Redis server assumption to 3.x
- Routes PING on Subscription keepalives over the subscription bridge appropriately
- Fixes cluster sharding from default(RedisKey) to shared logic for RedisChannel as well (both in byte[] form)
- General code cleanup in the area (getting a lot of DEBUG/VERBOSE noise into isolated files)

@NickCraver

@NickCraver

@NickCraver

@NickCraver

@NickCraver NickCraver changed the base branch from main to craver/pub-sub-prep

January 20, 2022 16:54

@NickCraver

@NickCraver

This is something that tripped me and at least 1 user up - let's save some pain.

@NickCraver

This is effectively the behavior we had before (but we are ensured connected now). We just want the count here and to start them, so let's do that also pipelining the `n` commands as we did before instead of awaiting each. We also don't need the `Task` overhead. This makes moving to a variadic command set for this less urgent.

mgravell

mgravell

This was referenced

Feb 4, 2022

This was linked to issues

Feb 6, 2022

@NickCraver NickCraver linked an issue

Feb 6, 2022

that may be closed by this pull request

This was referenced

Feb 6, 2022