Home Original page

support for envoyproxy by rkarthick · Pull Request #1989 · StackExchange/StackExchange.Redis

@rkarthick

NickCraver

requested changes Feb 11, 2022 

Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>

NickCraver

@rkarthick

@rkarthick

@NickCraver

@NickCraver 

In waiting for the subscriber connection to connect _when it's not supported_, we were being dumb and waiting the full timeout to proceed. So...don't do that, do the right thing.

@NickCraver

NickCraver added a commit that referenced this pull request

Feb 19, 2022 
In investigating an issue in #1989, I found a few gaps. Overall:
1. Twemproxy has an out of date CommandMap, which propagated to Envoy.
2. We were expecting both interactive and subscription connections to complete to complete the async handler...but we shouldn't because subscriptions may be disabled.
3. RedisSubscriber changes on the sync path weren't validating the message (asserting the command map has it enabled).

This fixes all of the above and adds another test considering all 3.

rkarthick

NickCraver added a commit that referenced this pull request

Feb 22, 2022 
In investigating an issue in #1989, I found a few gaps. Overall:
1. Twemproxy has an out of date CommandMap, which propagated to Envoy.
2. We were expecting both interactive and subscription connections to complete to complete the async handler...but we shouldn't because subscriptions may be disabled.
3. RedisSubscriber changes on the sync path weren't validating the message (asserting the command map has it enabled).

This fixes all of the above and adds another test considering all 3.

@NickCraver

@NickCraver

NickCraver

NickCraver

NickCraver added a commit that referenced this pull request

Feb 22, 2022

@NickCraver