Add ConfigurationOptions.BeforeSocketConnect by NickCraver · Pull Request #2031 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
Add ConfigurationOptions.BeforeSocketConnect#2031
NickCraver merged 3 commits intomainfrom
Add ConfigurationOptions.BeforeSocketConnect#2031
NickCraver merged 3 commits intomainfrom
Conversation
Copy link Copy Markdown
Collaborator
NickCraver
commented
Mar 10, 2022
NickCraver
commented
This adds a new config Action that allows modification of a socket after creating it and before connecting. It's passing the endpoint and connection type as well so if necessary per-connection options can be set.
Resolves #1472.
This adds a new config `Action` that allows modification of a socket after creating it and before connecting. It's passing the endpoint and connection type as well so if necessary per-connection options can be set. Resolves #1472.
NickCraver
added
➕ enhancement
⚙️ area:API
labels
NickCraver
mentioned this pull request
Closed
Copy link Copy Markdown
Collaborator
philon-msft
commented
Mar 10, 2022
philon-msft commented
Mar 10, 2022Is there a good spot in docs to mention this?
Copy link Copy Markdown
Collaborator Author
NickCraver
commented
Mar 10, 2022
NickCraver commented
Mar 10, 2022@philon-msft oh yeah the config docs should get some love - good call!
Copy link Copy Markdown
Collaborator Author
NickCraver
commented
Mar 10, 2022
NickCraver commented
Mar 10, 2022@philon-msft done :)
NickCraver
requested review from
mgravell and
philon-msft
philon-msft approved these changes Mar 10, 2022
NickCraver
merged commit
7ff36c5
into
main
NickCraver
deleted the
craver/config-beforesocketconnect
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment