ILogger for ConnectionMultiplexer by NickCraver · Pull Request #2051 · StackExchange/StackExchange.Redis
added 11 commits
March 19, 2022 19:40- Moves IncludeDetailInExceptions and IncludePerformanceCountersInExceptions from ConnectionMultiplexer to ConfigurationOptions (with backwards compatible APIs). - Move to a cleaner TryGetTieBreaker approach instead of Sentinel defaults needing to set it.
This needs a suite of tests but basically we're cloning the bits we don't want to fork from RawConfig (ConfigurationOptions ref on ConnectionMultiplexer). This may seem minor, but the net impact is a user can hold on to a ConfigurationOptions passed in and further modify it, e.g. to rotate passwords, etc. upstream. A few things we still clone are called out explicitly in the ConfigurationOptions docs.
This hasn't worked in some time - properly [Obsolete] it and point to the effective option on SocketManagerOptions.
Base automatically changed from craver/config-cleanup to main
March 26, 2022 00:41
NickCraver
changed the title
WIP: ILogger for ConnectionMultiplexer
In-progress: ILogger for ConnectionMultiplexer
Trying to figure out what the heck is affecting test replicas failing the primary role test...we have some new cause here.
NickCraver
changed the title
In-progress: ILogger for ConnectionMultiplexer
ILogger for ConnectionMultiplexer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters