ILogger for ConnectionMultiplexer by NickCraver · Pull Request #2051 · StackExchange/StackExchange.Redis

added 11 commits

March 19, 2022 19:40
- Moves IncludeDetailInExceptions and IncludePerformanceCountersInExceptions from ConnectionMultiplexer to ConfigurationOptions (with backwards compatible APIs).
- Move to a cleaner TryGetTieBreaker approach instead of Sentinel defaults needing to set it.
This needs a suite of tests but basically we're cloning the bits we don't want to fork from RawConfig (ConfigurationOptions ref on ConnectionMultiplexer). This may seem minor, but the net impact is a user can hold on to a ConfigurationOptions passed in and further modify it, e.g. to rotate passwords, etc. upstream. A few things we still clone are called out explicitly in the ConfigurationOptions docs.
This hasn't worked in some time - properly [Obsolete] it and point to the effective option on SocketManagerOptions.
Cleaning these up for a 3.x move down the road.

Base automatically changed from craver/config-cleanup to main

March 26, 2022 00:41

@NickCraver

NickCraver

mgravell

mgravell

petrroll

@NickCraver

@NickCraver

@NickCraver NickCraver changed the title WIP: ILogger for ConnectionMultiplexer In-progress: ILogger for ConnectionMultiplexer

Oct 24, 2022

@NickCraver

Trying to figure out what the heck is affecting test replicas failing the primary role test...we have some new cause here.

@NickCraver

The old version uses Node 12 which will break - fix it now :)

@NickCraver NickCraver changed the title In-progress: ILogger for ConnectionMultiplexer ILogger for ConnectionMultiplexer

Aug 12, 2023

mgravell

philon-msft

@NickCraver

@NickCraver

niemyjski