Support OBJECT ENCODING by Avital-Fine · Pull Request #2088 · StackExchange/StackExchange.Redis
Navigation Menu
{{ message }}
StackExchange / StackExchange.Redis Public
- Notifications You must be signed in to change notification settings
- Fork 1.6k
Merged
NickCraver merged 10 commits intoStackExchange:mainfrom
Avital-Fine:KeyEncoding
NickCraver merged 10 commits intoStackExchange:mainfrom
Avital-Fine:KeyEncoding
Conversation
Copy link Copy Markdown
Contributor
Avital-Fine
commented
Apr 13, 2022
Avital-Fine
commented
NickCraver requested changes Apr 13, 2022
Copy link Copy Markdown
Collaborator
NickCraver
left a comment
NickCraver
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good - main thing is return type should be string? on these APIs
src/StackExchange.Redis/Interfaces/IDatabase.cs
Outdated
Show resolved
Hide resolved
src/StackExchange.Redis/Interfaces/IDatabase.cs Outdated Show resolved Hide resolved
src/StackExchange.Redis/Interfaces/IDatabaseAsync.cs
Outdated
Show resolved
Hide resolved
src/StackExchange.Redis/Interfaces/IDatabaseAsync.cs Outdated Show resolved Hide resolved
tests/StackExchange.Redis.Tests/Keys.cs
Outdated
Show resolved
Hide resolved
tests/StackExchange.Redis.Tests/Keys.cs Outdated Show resolved Hide resolved
src/StackExchange.Redis/Interfaces/IDatabase.cs
Outdated
Show resolved
Hide resolved
src/StackExchange.Redis/Interfaces/IDatabase.cs Outdated Show resolved Hide resolved
src/StackExchange.Redis/Interfaces/IDatabaseAsync.cs
Outdated
Show resolved
Hide resolved
src/StackExchange.Redis/Interfaces/IDatabaseAsync.cs Outdated Show resolved Hide resolved
Avital-Fine added 2 commits
April 13, 2022 16:38
slorello89
mentioned this pull request
Avital-Fine and others added 6 commits
April 14, 2022 08:51Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Co-authored-by: Nick Craver <nrcraver@gmail.com>
Avital-Fine
requested a review
from NickCraver
NickCraver approved these changes Apr 14, 2022
Copy link Copy Markdown
Collaborator
NickCraver
left a comment
NickCraver
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks :)
NickCraver
merged commit
567527d
into
StackExchange:main
NickCraver
added
➕ enhancement
⚙️ area:commands
⚙️ area:API
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment