The new features were added to Redis 7: now the indexes of both commands (BITCOUNT and BITPOS) can be specified in BITs instead of BYTEs.

(Also added tests for BitPosition since it was missing)

In this case, I'd guess we want an overload, e.g. with StringIndexType.Bit/Byte (defaulting to Byte) before CommandFlags - thoughts?

In this case, I'd guess we want an overload, e.g. with StringIndexType.Bit/Byte (defaulting to Byte) before CommandFlags - thoughts?

Yes, I was considering that but we can't make a default if we overload.

@NickCraver I can do overload without a default if you think it's better

We can do with a default, we just need to make sure not to break the old method - see #2098 where I'm doing a setup to ensure it's not broken by testing all overload options someone could be using - we'd want to do the same here. You could merge that PR branch in here and point this PR at that branch instead of main, since it'll merge first and has the test clas in place and such.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Nick Craver <nrcraver@gmail.com>

Co-authored-by: Nick Craver <nrcraver@gmail.com>

Co-authored-by: Nick Craver <nrcraver@gmail.com>

Co-authored-by: Nick Craver <nrcraver@gmail.com>

Co-authored-by: Nick Craver <nrcraver@gmail.com>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.