Support GT, LT and CH in ZADD command by Avital-Fine · Pull Request #2136 · StackExchange/StackExchange.Redis

Conversation

@Avital-Fine

SortedSetAdd currently not supporting GT and LT features.

Also, CH is not supported. @NickCraver Should I add it here in this PR too?

@NickCraver

I think we should do all the things at once here given it's the same overloads, yep - @mgravell and I are unsure about the When because the options are more complex/confusing. But we should tackle the CH and INCR at the same time given it's all the same method ultimately. I'm back in action this week so trying to resume PRs tonight.

@Avital-Fine

Great! Glad you're back :)
Are you sure about the INCR option? Because it's exactly like using SortedSetIncrement 😅

@NickCraver

Hmm yeah okay let's ignore for now - plan is if someone needs the combo of these args and INCR, then we can add it to SortedSetIncrement down the road :)

@NickCraver

@Avital-Fine talking about this in call - can we please try renaming the When to SortedSetWhen which has all the members? Then we don't have the existing When in the new overload - it's an overall change to this [Flags] enum to specify the options.

/cc @mgravell

@Avital-Fine

@Avital-Fine talking about this in call - can we please try renaming the When to SortedSetWhen which has all the members? Then we don't have the existing When in the new overload - it's an overall change to this [Flags] enum to specify the options.

/cc @mgravell

Maybe we can add SortedSetAddFlags and then we can include there CH flag? WDYT?

@Avital-Fine

Also it will be super easy to support INCR

Avital-Fine added 2 commits

May 12, 2022 13:16

@Avital-Fine Avital-Fine changed the title Support GT and LT in ZADD command Support GT, LT and CH in ZADD command

May 13, 2022

@Avital-Fine

@NickCraver

@Avital-Fine ACK! Sorry I've been swamped and not on this hardly at all - @mgravell is going to give compat eyes here :)

mgravell